Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subquery as function arg w/o parens in Snowflake dialect #996

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Support subquery as function arg w/o parens in Snowflake dialect #996

merged 2 commits into from
Oct 23, 2023

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented Oct 6, 2023

This adds support for a Snowflake quirk where the enclosing parentheses around a subquery can be omitted if it's the only argument to a function.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6437141511

  • 13 of 15 (86.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 87.353%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 9 11 81.82%
Totals Coverage Status
Change from base Build 6435373786: -0.001%
Covered Lines: 16791
Relevant Lines: 19222
💛 - Coveralls

alamb
alamb approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jmhain

@alamb alamb changed the title snowflake: support subquery as function arg w/o parens Support subquery as function arg w/o parens in Snowflake dialect Oct 23, 2023
@alamb alamb merged commit 56f24ce into apache:main Oct 23, 2023
10 checks passed
@jmhain jmhain deleted the subquery-function-arg branch October 23, 2023 23:50
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@jmhain @serprex
Support subquery as function arg w/o parens in Snowflake dialect (apa…
e2fa7bb 
…che#996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmhain @coveralls @alamb